Resolve FIXME in sugarscape_g1mt/agents.py via zip (mesa#3062)

Sonu0305 · web-flow · commit 6ffee80c0180 · 2026-01-05T15:02:05.000+01:00
diff --git a/mesa/examples/advanced/sugarscape_g1mt/agents.py b/mesa/examples/advanced/sugarscape_g1mt/agents.py
@@ -239,15 +239,13 @@ def move(self):
 
         # find the highest welfare in welfares
         max_welfare = max(welfares)
-        # get the index of max welfare cells
-        # fixme: rewrite using enumerate and single loop
-        candidate_indices = [
-            i for i in range(len(welfares)) if math.isclose(welfares[i], max_welfare)
+        # Get cells with the highest welfare
+        candidates = [
+            cell
+            for cell, welfare in zip(neighboring_cells, welfares)
+            if math.isclose(welfare, max_welfare)
         ]
 
-        # convert index to positions of those cells
-        candidates = [neighboring_cells[i] for i in candidate_indices]
-
         min_dist = min(get_distance(self.cell, cell) for cell in candidates)
 
         final_candidates = [
