Conversation
they were hardly used, are a bad practice to use and difficult to guess the correct mode of the algorithm. Explicit is better then implicit.
Collaborator
|
I did notice unexpected behavior sometimes setting thresholds, so nice that it's revisited. This will be a breaking change without backwards compatibility right? |
Owner
Author
|
Yes, most of the PRs of the last couple of weeks are not backward compatible. The version number on master is 3.0.0-dev because of this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the threshold and threshold_type argument/keyword argument from PRIM.
Because they were overloaded to control prim's behavior when run in regression mode (a not well-known or documented feature) the changes are a bit more involved.
Overall, I now cleanly separate 2 versions of the algorithm: binary for scenario discovery, and regression (original behavior of PRIM).
closes #412
TODO