Conversation
cleanup and code simplification shift to using qmc for lhs centralized rescaling for non uniform distributions in base class rewrite tests add type hints and update docstrings
quaquel
changed the title
make it work, update docs, harmonize API across normal and salib samplers
ruff fixes, type hints, all for integration testing of other changes in this pr
ruff fixes and type hints as part of integration testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR at its core does two things: at long last enable control over the random seed in a Spec-7 compliant way and a shift to using scipy.stats.qmc for LHS sampling.
As part of this, a long list of smaller changes and modifications have also been needed/convenient to implement at this point
scipy.stats.qmcrngin line with spec-7. This also at long last closes Add control for random state #62BaseEvaluator.perform_experiment. The exact keywords that are valid depend on the underlying sampler and are documented for each sampler.TODO
cleanup type hints forrng, which are currently not fully correctadd a note to salib samplers because of inconsistencies in salib's use of seed (see Shift to using numpy.random.Generator and harmonize signature of seed across all sample functions SALib/SALib#662)