Add a flag to VensimModel to change underscores to white space in Variable names#405
Merged
Add a flag to VensimModel to change underscores to white space in Variable names#405
Conversation
avoids code duplication
make sure model.constants is mocked as well
add constants stuff to run model calls
4625f85 to
8fefddd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 3.0, all variables and model names must be valid python identifiers. This is highlly inconvenient for Vensim models where it is the convention to use white space instead of underscores. This PR adds a flag to
VensimModelto automatically map the name of all variables from being a valid python identifier (i.e., with underscores) to being valid for Vensim (i.e., replace underscores with white space).In addition, it cleans up a whole bunch of technological debt and other minor bugs found along the way. Most notably
_tranformas wellsample_uncertaintiescloses #393