Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Making this change is rough. The main issue is that to enable ruff for pre-commit the code base itself should already be fully compatible with ruff. At the moment, there are 1844 errors that cannot be fixed automatically. So, atm pre-commit is commented out.

update: if I add a bunch of exclude directories to pyproject.toml limiting ruff to ema_workbench only, we are left with 1184 errors. Adding test as well, moves it up to 1789. I am inclined to first fix everything in the source code and leave tests for later.

I fixed all ruff issues in the analysis package. This leaves another 813 errors in the other ema_workbench packages. Not sure whether I am going to fix these with this PR or leave them for future PRs. It's boring work fixing them, and I want to work on other outstanding issues.

I fixed em_framework as well, leaving 408 ruff errors in examples, connectors, and util.

Given some of the open issues, I am unsure whether I want to fix examples (214 errors) and connectors (150 errors) at the moment. I might still do util (43 errors).

merging this, with an awareness that examples, connectors and uti still need fixing and that docs and tests are currently excluded.