Conversation
This is a release branch
* bugfix to finalizer fixes a bug in the finalizer in case of working directory models * Update futures_util.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Fixes a mistake in the MPI evaluator where the pool is created twice (probably some code merging issue in the past) * cleans up the mpi example and associated slurm file. * additional logging messages
updates: - [github.com/psf/black: 24.3.0 → 24.4.0](psf/black@24.3.0...24.4.0) - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) [pre-commit.ci] pre-commit autoupdate (#345) * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/psf/black: 23.12.0 → 24.2.0](psf/black@23.12.0...24.2.0) - [github.com/asottile/pyupgrade: v3.15.0 → v3.15.1](asottile/pyupgrade@v3.15.0...v3.15.1) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- [pre-commit.ci] pre-commit autoupdate (#347) updates: - [github.com/psf/black: 24.2.0 → 24.3.0](psf/black@24.2.0...24.3.0) [pre-commit.ci] pre-commit autoupdate (#352) updates: - [github.com/asottile/pyupgrade: v3.15.1 → v3.15.2](asottile/pyupgrade@v3.15.1...v3.15.2) Co-Authored-By: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
np.NaN will be removed in NumPy 2.0.
* Clear up DelftBlue tutorial A few minor clarifications to the DelftBlue part of the MPI tutorial. * MPI tutorial: pip upgrade existing EMAworkbench installation This makes sure users don't accidently keep using an older version if they installed it previously.
* fixes a platypus related warning * pandas related plotting fix * Update optimization.py * pandas related fix to ensure index col is handled properly * platypus fix for warning * Update optimization.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix for linter error * Update b_and_w_plotting.py matplotlib related * matplotlib related fix * work arround for python3.9 vs 3.10 and knock on for matplotlib --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ewout ter Hoeven <[email protected]>
* version bump and backport of pre-commit * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
EwoutH
reviewed
Aug 14, 2025
Collaborator
EwoutH
left a comment
EwoutH
left a comment
There was a problem hiding this comment.
I don’t have (access to) a system to test this on currently, but aside from two small remarks it looks good.
Collaborator
There was a problem hiding this comment.
How is loading / installing Python modules now handles? I don’t find that totally clear yet.
Owner
Author
There was a problem hiding this comment.
I can't find a clear explanation in the docs. I just installed stuff via the command line while being logged in and in the scratch directory.
remove paths stuff used in testing
Owner
Author
|
I have confirmed that the latest commit works as intended on Delft Blue. I am still figuring out the tutorial side of things and, in particular, how to correctly install the workbench and other dependencies. For testing, I just scp'ed the workbench to scratch and modified the example to add this folder to the top of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains various small changes to the MPI related code. It makes sure the tutorial and example are up to date with DelftBlue, and it fixes an incompatibility with mpi4py 4.x. It also changes around some of the log levels in the mpi evaluator to make it easier to diagnose problems.