Skip to content

Teaching fixes#379

Merged
quaquel merged 19 commits into2.5-releasefrom
teaching_fixes
Apr 23, 2025
Merged

Teaching fixes#379
quaquel merged 19 commits into2.5-releasefrom
teaching_fixes

Conversation

@quaquel
Copy link
Copy Markdown
Owner

@quaquel quaquel commented Apr 22, 2025 •
edited
Loading

This is a maintenance PR that fixes various errors and warnings due to updates in dependencies of the workbench, such as pandas, matplotlib, and platypus-opt.

quaquel and others added 14 commits April 22, 2025 11:12
@quaquel
fixes a platypus related warning
2f6e367
@quaquel
pandas related plotting fix
df4dd15
@quaquel
Update optimization.py
21e2dfc
@quaquel
pandas related fix to ensure index col is handled properly
a79cf92
@quaquel
platypus fix for warning
bde9df6
@quaquel
Update optimization.py
150e389
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4c8e5df 
for more information, see https://pre-commit.ci
@quaquel
fix for linter error
98e7593
@quaquel
Merge branch 'teaching_fixes' of https://github.com/quaquel/EMAworkbench
6cf65d9 
 into teaching_fixes
@quaquel
Update b_and_w_plotting.py
924e51f 
matplotlib related
@quaquel
matplotlib related fix
6830c7c
@quaquel
move to require 3.10
67c0fe1
@quaquel
Revert "move to require 3.10"
00192f7 
This reverts commit 67c0fe1.
@quaquel
work arround for python3.9 vs 3.10 and knock on for matplotlib
f5c0fd9
@EwoutH
Copy link
Copy Markdown
Collaborator

EwoutH commented Apr 22, 2025

Let me know if you would like a review!

@quaquel
Copy link
Copy Markdown
Owner Author

quaquel commented Apr 23, 2025

If you have time for a review today, that would be very welcome.

I will have to merge this somewhere today and do a new release because teaching starts tomorrow. That is also partially why I deviated from atomic PR's and just collected a bunch of small fixes (all dependency-related) together in this PR.

EwoutH
EwoutH reviewed Apr 23, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments, feel free to ignore any that aren't useful or proportional of your time.

One question: Are there any breaking changes in the user-facing API or functionality?

@quaquel
Copy link
Copy Markdown
Owner Author

quaquel commented Apr 23, 2025

One question: Are there any breaking changes in the user-facing API or functionality?

No, I deliberately made sure to avoid this.

EwoutH
EwoutH approved these changes Apr 23, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few minor optional suggestions, pre-approving.

@quaquel quaquel merged commit c20d3f5 into 2.5-release Apr 23, 2025
16 of 20 checks passed
@quaquel quaquel deleted the teaching_fixes branch April 23, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EwoutH EwoutH EwoutH approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quaquel @EwoutH