Use PlatypusConfig.default_variator#369
Merged
EwoutH merged 2 commits intoquaquel:masterfrom Sep 9, 2024
dhadka:dhadka/fix-platypus
Merged
Use PlatypusConfig.default_variator#369EwoutH merged 2 commits intoquaquel:masterfrom dhadka:dhadka/fix-platypus
EwoutH merged 2 commits intoquaquel:masterfrom
dhadka:dhadka/fix-platypus
Conversation
Collaborator
|
Thanks a lot for not only getting back, but also directly suggesting/implementing two potential fixes! @quaquel, for your context, this PR originated from an issue I filed to Platypus after seeing our weekly CI fail: Project-Platypus/Platypus#246 |
Owner
|
Thanks @dhadka! I'll take a closer look as soon as possible. |
Contributor
Author
|
FYI, I've decided to put those methods back since it's a breaking change, but probably with a warning to switch to the new methods. I should have the version out in the next few hours. Though I would still recommend switching to the class version eventually. |
Collaborator
|
Thanks! The diligent follow ups are really appreciated! @quaquel we have two options:
|
Owner
|
I am fine with option 1, requires updating the toml I guess? |
Collaborator
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version
1.3.0moveddefault_variatorfrom a standalone method to part ofPlatypusConfig. Thus, this updates the method reference and puts a minimum version on the dependency.Alternatively, if you want to allow either version, you could use something like: