Skip to content

Clear up DelftBlue tutorial#359

Merged
EwoutH merged 2 commits intomasterfrom
mpi-tutorial
May 24, 2024
Merged

Clear up DelftBlue tutorial#359
EwoutH merged 2 commits intomasterfrom
mpi-tutorial

Conversation

@EwoutH
Copy link
Copy Markdown
Collaborator

@EwoutH EwoutH commented May 23, 2024

A few minor clarifications to the DelftBlue part of the MPI tutorial.

@EwoutH EwoutH added the docs label May 23, 2024
@EwoutH EwoutH requested a review from quaquel May 23, 2024 17:11
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@EwoutH
Copy link
Copy Markdown
Collaborator Author

EwoutH commented May 24, 2024

I added a --upgrade argument to the pip install ema_workbench in the tutorial.

Test failures are unrelated, this PR is docs only.

Copy link
Copy Markdown
Owner

@quaquel quaquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reason for these changes? It's just to make sure we use the modern super call? but if so, it should be its own (maintenance) PR?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The super stuff points.py was automatically added by pre-commit.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, after the merge of #357 it's now gone from this PR.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, excellent. LGTM unless you expect further changes.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this PR, this is it.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EwoutH added 2 commits May 24, 2024 14:53
A few minor clarifications to the DelftBlue part of the MPI tutorial.
This makes sure users don't accidently keep using an older version if they installed it previously.
@EwoutH EwoutH merged commit ce7261a into master May 24, 2024
@EwoutH EwoutH deleted the mpi-tutorial branch May 24, 2024 13:35
EwoutH added a commit that referenced this pull request May 24, 2024
* Clear up DelftBlue tutorial
A few minor clarifications to the DelftBlue part of the MPI tutorial.

* MPI tutorial: pip upgrade existing EMAworkbench installation

This makes sure users don't accidently keep using an older version if they installed it previously.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants