Skip to content

bug fix in MPI evaluator#349

Merged
quaquel merged 24 commits intomasterfrom
mpi_fixes
Apr 7, 2024
Merged

bug fix in MPI evaluator#349
quaquel merged 24 commits intomasterfrom
mpi_fixes

Conversation

@quaquel
Copy link
Copy Markdown
Owner

@quaquel quaquel commented Mar 20, 2024

Fixes a mistake in the MPI evaluator where the pool is created twice (probably some code merging issue in the past)

It also cleans up the mpi example and associated slurm file.

NB: this code segfaults on DelftBlue during shut down. I still need to investigate this. It seems related to the treading used for handling logging.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 20, 2024

Coverage Status

coverage: 80.212% (-0.09%) from 80.3%
when pulling 6b48e3e on mpi_fixes
into 10429e4 on master.

Copy link
Copy Markdown
Collaborator

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@quaquel
Copy link
Copy Markdown
Owner Author

quaquel commented Mar 20, 2024

I found the source of the segfault. Long story short: deamonic threads and mpi don't mix. Now I need to find a proper fix to ensure that the log watcher thread terminates correctly instead of being shut down by a time out.

@EwoutH
Copy link
Copy Markdown
Collaborator

EwoutH commented Mar 28, 2024

This commit log describes my experience developing the first iteration of the MPIEvaluator remarkably well.

I feel your pain.

@quaquel
Copy link
Copy Markdown
Owner Author

quaquel commented Mar 29, 2024

yes testing and debugging mpi is tricky. Even more so because of openmpi on delftblue vs. mpich on my mac. This all now seems to work, although occasionally, it hangs during start up on delft blue for unclear reasons.

@quaquel quaquel marked this pull request as ready for review April 7, 2024 08:47
@quaquel quaquel merged commit 089a9f0 into master Apr 7, 2024
@quaquel quaquel deleted the mpi_fixes branch April 7, 2024 08:53
EwoutH pushed a commit that referenced this pull request Apr 17, 2024
* Fixes a mistake in the MPI evaluator where the pool is created twice (probably some code merging issue in the past)
* cleans up the mpi example and associated slurm file.
* additional logging messages
@EwoutH EwoutH added the bug label Apr 17, 2024
@EwoutH
Copy link
Copy Markdown
Collaborator

EwoutH commented May 23, 2024

When running the tutorial I now get this error:

image

I don't see a line change there, but could this PR have caused it in some other way?

And it seems the current source code is also correct:

def log_to_stderr(level=None, pass_root_logger_level=False):

@quaquel
Copy link
Copy Markdown
Owner Author

quaquel commented May 23, 2024

are you sure you have the correct version of the workbench installed (this caused me various headaches before).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants