Conversation
Adds a simple example for controlling Mesa models with the Workbench, using the Virus on a Network model.
quaquel
left a comment
quaquel
left a comment
There was a problem hiding this comment.
Thanks a lot for this! just a few minor tweaks and it is ready to merge
|
|
||
| # Define model outcomes | ||
| model.outcomes = [ | ||
| TimeSeriesOutcome("TIME"), |
There was a problem hiding this comment.
why do you include time here?
and since you use a replicator model, these should all be replaced with ArrayOutcomes
There was a problem hiding this comment.
I have a dim recollection of some EMA plotting functions breaking (or giving a warning?) if there is no TIME dimension, so this was probably included to preclude that.
There was a problem hiding this comment.
With ArrayOutcomes these will break anyway. Also, the time problem is now fixed and only will give a warning.
|
Looks great, thanks a lot! To fully close #102 I think we should also add a simple model to the basic tutorial (here on GitHub). Then from there we can link to this as a more extensive example. But that can be done in a separate PR. |
EwoutH
left a comment
EwoutH
left a comment
There was a problem hiding this comment.
Runs and reasonably well documented, so aside the comments from Jan, LGTM!
Thanks!
4 participants
Adds a simple example for controlling Mesa models with the Workbench, using the Virus on a Network model. The integration was originally developed by myself and @mikhailsirenko for the Social Simulation Festival 2021. If accepted, this closes #102 .