Conversation
quaquel
reviewed
Nov 17, 2023
Owner
quaquel
left a comment
quaquel
left a comment
There was a problem hiding this comment.
should test_evaluators be part of this. otherwise fine.
Collaborator
Author
|
I will keep the separate commits when merging. |
Add Python 3.12 to CI testing by switching all default jobs to 3.12. Python 3.9 to 3.11 is still tested.
This commit resolves an AttributeError in the test_ipyparallel_evaluator method of the TestEvaluators class. The error was caused by the use of a non-existent method called_once() on a mock object. The correct method, assert_called_once(), has been applied to ensure the proper assertion of the mocked method's call frequency. This change ensures the test aligns with the intended functionality and adheres to the correct usage of the unittest.mock library in Python.
EwoutH
force-pushed
the
python-3.12-ci
branch
from
dce86d8 to
94234ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Python 3.12 to CI testing by switching all default jobs to 3.12. Python 3.9 to 3.11 is still tested.