Speed up of plot_discrete_cdfs by 2 orders of magnitude#306
Merged
Conversation
handling of default columns in experiments dataframe changed to properly remove scenario_id as well as model and/or policy if there is only one value for these. removal of scatter plot in plot_discrete_cdf for 2 orders of magnitude speedup
Collaborator
|
Thanks, will review later this week. Is this in any way breaking for current users / workflows? |
Owner
Author
this change won't break anything major because it is just a visual change. |
EwoutH
reviewed
Nov 2, 2023
Collaborator
|
Before this PR: Goes from 345 seconds to 2. And looking at the CI test times, it goes from 8 to 10 minutes to around 3 minutes. Great work! |
EwoutH
approved these changes
Nov 3, 2023
Collaborator
|
Could you make the PR title more descriptive (for the changelog) and then feel free to (squash and) merge. |
quaquel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request does 3 things
plot_discrete_cdfsby 2 orders of magnitudeplot_cdfsfor handling scenario_id, policy, and modelCloses #298