examples: Speedup the lake_problem function by ~30x#301
Merged
Conversation
Speed up the lake_problem function by around 30x. Benchmark: Average duration of 100 lake_model experiments: 0.940 seconds vs 0.030 seconds (speed up: 31.41). I validated the output and it is consistent with the previous output. The improved performance might allow more and broader analysis to be done in the exercises. Also print a warning on the decisions KeyError
Owner
|
Looks good, I think I made basically this change to the code used in teaching |
quaquel
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speedup the
lake_problemfunction in theexample_lake_model.pyexample.This is an one-on-one adaptation of https://github.com/quaquel/epa1361/pull/4.
Also add a warning on the decisions KeyError.