em_framework/points: Add string representation to Experiment class#297
Merged
em_framework/points: Add string representation to Experiment class#297
Conversation
quaquel
reviewed
Oct 13, 2023
Owner
quaquel
left a comment
quaquel
left a comment
There was a problem hiding this comment.
The basic idea is fine. However, repr ideally should return something that can be used to reinstantiate the object. The current information is not correctly formatted for this. See e.g., https://realpython.com/python-repr-vs-str/ for details
.__repr__() provides the formal string representation of an object, aimed at the programmer. .__str__() provides the informal string representation of an object, aimed at the user.
Collaborator
Author
|
Thanks for reviewing, good point. How does this look? (if good, please squash when merging) |
Collaborator
Author
|
@quaquel Any further comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cherry pick from #292 to give the Experiment class in points.py a string representation. This can be useful for keeping track of different experiments being performed while logging.