bugfix for #277 : load_results properly handles experiments dtypes#280
Merged
bugfix for #277 : load_results properly handles experiments dtypes#280
Conversation
EwoutH
reviewed
Jun 18, 2023
EwoutH
reviewed
Jun 18, 2023
EwoutH
approved these changes
Jun 18, 2023
Collaborator
EwoutH
left a comment
EwoutH
left a comment
There was a problem hiding this comment.
One last comment on the test, the rest looks good, thanks!
Do you want this into 2.4.1?
…o dtype as specified in metadata bugfix for load_results. In parsing experiments, the dtype metadata is now correctly applied. Also expands save)results unittest to cover all dtypes used in storing experiments.
EwoutH
force-pushed
the
load_results_bugfix
branch
from
bdfadbc to
23648de
Compare
EwoutH
pushed a commit
that referenced
this pull request
Jun 18, 2023
* bugfix for #277 : load_results now casts all columns in experiments to dtype as specified in metadata bugfix for load_results. In parsing experiments, the dtype metadata is now correctly applied. Also expands save)results unittest to cover all dtypes used in storing experiments. * small typo in test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix for load_results which fixes #277. In parsing experiments, the dtype metadata is now correctly applied. It also expands save_results unit test to cover all dtypes used in storing experiments.