Skip to content

docs/examples: Always use n_processes=-1 in MultiprocessingEvaluator#278

Merged
quaquel merged 2 commits intomasterfrom
n_processes-1
Jun 14, 2023
Merged

docs/examples: Always use n_processes=-1 in MultiprocessingEvaluator#278
quaquel merged 2 commits intomasterfrom
n_processes-1

Conversation

@EwoutH
Copy link
Copy Markdown
Collaborator

@EwoutH EwoutH commented Jun 14, 2023

Modify the docs and examples to always use n_processes=-1 in MultiprocessingEvaluator. This ensure that when a user runs them, they always use most of their cores while keeping one core available for background tasks and to keep the system responsive.

The n_processes=-1 was implemented in #140 and has been available since version 2.2.0 of the EMAworkbench.

Modify the docs and examples to always use n_processes=-1 in MultiprocessingEvaluator. This ensure that when a user runs them, they always use most of their cores while keeping one core available for background tasks and to keep the system responsive.
@EwoutH EwoutH added the docs label Jun 14, 2023
@EwoutH EwoutH requested a review from quaquel June 14, 2023 08:33
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 14, 2023

Coverage Status

coverage: 81.097%. remained the same when pulling b39badf on n_processes-1 into b8748d9 on master.

@quaquel
Copy link
Copy Markdown
Owner

quaquel commented Jun 14, 2023

good idea, but perhaps annotate the code with a short comment explaining the meaning of -1.

@EwoutH
Copy link
Copy Markdown
Collaborator Author

EwoutH commented Jun 14, 2023

Thanks, added them, please squash when merging.

@quaquel quaquel merged commit cccad48 into master Jun 14, 2023
EwoutH added a commit that referenced this pull request Jun 18, 2023
…278)

* docs/examples: Always use n_processes=-1 in MultiprocessingEvaluator

Modify the docs and examples to always use n_processes=-1 in MultiprocessingEvaluator. This ensure that when a user runs them, they always use most of their cores while keeping one core available for background tasks and to keep the system responsive.

* docs/tutorial: Add comments
@quaquel quaquel deleted the n_processes-1 branch November 18, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants