Conversation
Replace altair.selection_single() with altair.selection_point(), since the former is deprecated in Altair 5.0.0.
Owner
|
The reason that its not covered by the CI is that, if I recall correctly, there were a few remaining things in the code I wanted to polish. But then covid came. This is also why I haven't documented it in much detail. |
Fix the Altair Chart used in inspect_tradeoff(), by using Chart().add_selection() instead of the removed Chart().properties(selector=). This fixed the inspect_tradeoff() when using Altair 5.0.0.
Collaborator
Author
quaquel
approved these changes
May 17, 2023
Owner
|
Go ahead and merge this if it now is ready to be merged. |
Collaborator
Author
|
Done! We might want to cherry pick this into a 2.5.1 release, I can do that Monday if you agree. |
Owner
|
There is another weird thing in the pca preprocessing that ideally I'll investigate and fix as part of that as well |
EwoutH
added a commit
that referenced
this pull request
Jun 18, 2023
* prim: Replace deprecated Altair function Replace altair.selection_single() with altair.selection_point(), since the former is deprecated in Altair 5.0.0. * prim: Fix Altair chart by using Chart().add_selection() Fix the Altair Chart used in inspect_tradeoff(), by using Chart().add_selection() instead of the removed Chart().properties(selector=). This fixed the inspect_tradeoff() when using Altair 5.0.0. * prim: Update deprecated Chart.add_selection() to .add_params() See https://altair-viz.github.io/releases/changes.html#grammar-changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
altair.selection_single()withaltair.selection_point(), since the former is deprecated in Altair 5.0.0.Do not merge yet, still running some tests.
Also note that Altair is not covered currently in our CI.