bugfix introduced by #241 in general-introduction from docs#265
Merged
bugfix introduced by #241 in general-introduction from docs#265
Conversation
#241 ensured that categorical uncertainties were properly handled in the experiment dataframe. The general introduction used an outdated fix for the same problem.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
|
So if I understand correctly, we unintendedly fixed a bug. I actually had a student stuck on this. Make the case again for using the tutorials as tests, by running them in CI (#205). Looks good, can you add a line to the 2.4.0 changelog somewhere, since this can actually be a breaking change for some people. |
EwoutH
approved these changes
Apr 24, 2023
Owner
Author
|
In #236, it was reported as a bug, and I used the additional tests in #241 to first diagnose it as a bug and then also fixed it. Basically, experiments before saving to disk and after loading from disk were not the same in case of categorical uncertainties. As such, it is unlikely to be a breaking change for most. |
EwoutH
pushed a commit
that referenced
this pull request
Jun 18, 2023
#241 ensured that categorical uncertainties were properly handled in the experiment dataframe. The general introduction used an outdated fix for the same problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#241 ensured that categorical uncertainties were properly handled in the experiment dataframe. The general introduction used an outdated fix for the same problem.