Skip to content

Fix pynetlogo imports by decapitalizing pyNetLogo#248

Merged
quaquel merged 1 commit intomasterfrom
pynetlogo
Apr 5, 2023
Merged

Fix pynetlogo imports by decapitalizing pyNetLogo#248
quaquel merged 1 commit intomasterfrom
pynetlogo

Conversation

@quaquel
Copy link
Copy Markdown
Owner

@quaquel quaquel commented Apr 5, 2023

Also change the jvmargs argument of the BaseNetLogoModel class to jvm_args. This makes is consistent with other argument and comply to snake_case.

Closes #245

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@quaquel quaquel requested a review from EwoutH April 5, 2023 07:12
@quaquel quaquel added this to the 2.4.0 milestone Apr 5, 2023
@quaquel quaquel added the bug label Apr 5, 2023
@quaquel quaquel self-assigned this Apr 5, 2023
@EwoutH
Copy link
Copy Markdown
Collaborator

EwoutH commented Apr 5, 2023

When did the name change from pyNetLogo to pynetlogo take place? We should document that somewhere well.

I think the commit message and PR title can be more descriptive, like: Fix pynetlogo imports by decapitalizing pyNetLogo

And then in the commit message the other change: Change the jvmargs argument of the BaseNetLogoModel class to jvm_args. This makes is consistent with other argument and comply to snake_case.

Code change itself looks good.

@quaquel
Copy link
Copy Markdown
Owner Author

quaquel commented Apr 5, 2023

The changes are documented in pynetlogo, and that is were it belongs.

I'll use the more descriptive message.

@quaquel quaquel merged commit 81fa67c into master Apr 5, 2023
@quaquel quaquel deleted the pynetlogo branch April 5, 2023 08:42
@EwoutH EwoutH changed the title fix for changes in pynetlogo Fix pynetlogo imports by decapitalizing pyNetLogo Apr 5, 2023
@EwoutH EwoutH changed the title Fix pynetlogo imports by decapitalizing pyNetLogo Fix pynetlogo imports by decapitalizing pyNetLogo Apr 5, 2023
@EwoutH
Copy link
Copy Markdown
Collaborator

EwoutH commented Apr 5, 2023

Thanks!

My criterea always is: "If I use git blame on this code change in 5 years, will the commit message give me insights why the change was made."

The why is very important here.

quaquel added a commit that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EMA cannot find pyNetLogo module - name change issue?

2 participants