Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
When did the name change from I think the commit message and PR title can be more descriptive, like: Fix pynetlogo imports by decapitalizing pyNetLogo And then in the commit message the other change: Change the jvmargs argument of the BaseNetLogoModel class to jvm_args. This makes is consistent with other argument and comply to snake_case. Code change itself looks good. |
|
The changes are documented in pynetlogo, and that is were it belongs. I'll use the more descriptive message. |
pynetlogo imports by decapitalizing pyNetLogo
|
Thanks! My criterea always is: "If I use git blame on this code change in 5 years, will the commit message give me insights why the change was made." The why is very important here. |
Also change the
jvmargsargument of the BaseNetLogoModel class tojvm_args. This makes is consistent with other argument and comply to snake_case.Closes #245