Skip to content

Fix for stalling tests#247

Merged
quaquel merged 4 commits intomasterfrom
stalling_tests
Apr 5, 2023
Merged

Fix for stalling tests#247
quaquel merged 4 commits intomasterfrom
stalling_tests

Conversation

@quaquel
Copy link
Copy Markdown
Owner

@quaquel quaquel commented Apr 5, 2023

Adds kwargs to Logit.run. These kwargs are passed on to statsmodels.Logit.fit.

By setting method to 'newton, and maxiter to 2, the tests are much less likely to stall.

@quaquel quaquel self-assigned this Apr 5, 2023
@quaquel quaquel requested a review from EwoutH April 5, 2023 07:06
@quaquel quaquel added this to the 2.4.0 milestone Apr 5, 2023

Parameters
----------
kwargs are passed on to model.fit
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give a few examples of kwargs that can be passed.

@EwoutH
Copy link
Copy Markdown
Collaborator

EwoutH commented Apr 5, 2023

PR/commit title: Fix stalling tests on Ubuntu by changing logitmodel.run method
Body:

- Also allows passing **kwargs to model.fit
- Disables testing of .show_tradeoff(), .show_threshold_tradeoff()_, .plot_pairwise_scatter() and .inspect()

Also please add a Closes #226 to the PR body.

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

… stalling

- Also allows passing **kwargs to model.fit

Closes #226
@quaquel quaquel merged commit 4f72cbe into master Apr 5, 2023
quaquel added a commit that referenced this pull request Apr 5, 2023
 It also allows passing **kwargs to model.fit
Closes #226
@quaquel quaquel deleted the stalling_tests branch November 18, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants