Fix Matplotlib, ipyparallel and dict deprecation warnings#202
Merged
Conversation
EwoutH
force-pushed
the
depreciations-2022-10
branch
from
2f797a3 to
f5c8220
Compare
quaquel
approved these changes
Oct 25, 2022
Collaborator
Author
|
Note to self: Do fast-forward merge |
Fix two cases of the following deprecation:
MatplotlibDeprecationWarning: MarkerStyle(None) is deprecated since 3.6; support will be removed two minor releases later. Use MarkerStyle('') to construct an empty MarkerStyle.
See matplotlib/matplotlib#21074
Replace 7 cases of the deprecated .iteritems() (from Python 2) being called, with the current items().
With the 3.6 release Matplotlib deprecated using `loc` as a positional keyword for the figure.legend function, making it a keyword only function starting from Matplotlib 3.8. This commit adds the `loc` keyword to the figure.legend and figlegend functions to resolve the depreciation warning and prepare for future Matplotlib versions.
DeprecationWarning: ipyparallel.apps.launcher is deprecated in ipyparallel 7. Use ipyparallel.cluster.launcher. See: ipython/ipyparallel#463
EwoutH
force-pushed
the
depreciations-2022-10
branch
from
f5c8220 to
ef9ecf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintenance in it's purest form. This PR fixed 4 types of deprecations:
MarkerStyle(None)deprecation in matplotlib by replacing it withMarkerStyle('').iteritems()with.items()for dictslocas a positional keyword inlegendfunctionslauncherfromipyparallel.clusterinstead ofipyparallel.appsI founds some others that might be less trivial, so I opened tracking issue (#201).