Merged
Conversation
This commit fixes a bunch of spelling mistakes, found and fixed by codespell v2.2.1. All fixes are checked by hand to be actually a fix for an actually misspelled word.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
Author
|
@quaquel Quick update on this effort, and a few questions:
Furthermore I looked into adding codespell to the pre-commit configuration. Unfortunately, it's still to too buggy for that, and mainly blocked by codespell-project/codespell#2138 (images in Jupyter Notebooks get sometimes corrupted). Which is a shame, because it would be really useful catching mistakes in PRs. |
Owner
|
Collaborator
Author
|
I threw out the spelling fixes in the Vensim models and the weird Juypter notebook image issue. I also resolved conflicts. This PR is now ready for review. Please squash when merging. |
quaquel
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a bunch of spelling mistakes, found and fixed by codespell v2.2.1. All fixes are checked by hand to be actually a fix for an actually misspelled word.
Still in draft because I need to check a few special cases and the Jupyter Notebooks.
Once those are fixed or added to a ignore list/file, I plan to also add codespell to the pre-commit CI to catch future errors.