Skip to content

Convergence tracking#193

Merged
EwoutH merged 15 commits intomasterfrom
convergence_tracking
Oct 19, 2022
Merged

Convergence tracking#193
EwoutH merged 15 commits intomasterfrom
convergence_tracking

Conversation

@quaquel
Copy link
Copy Markdown
Owner

@quaquel quaquel commented Oct 12, 2022 •
edited by EwoutH
Loading

This pull request entails an overhaul of how convergence tracking is being supported by the workbench. This closes #187.

In short:

  1. ArchiveLogger now stores results in a tarbal
  2. Additional helper functions for converting from a dataframe to a collection of platypus solutions
  3. Additional helper function for merging results from multiple seeds using epsilon non dominated sort
  4. All platypus convergence indicators are wrapped using a wrapper class to make them play nice with the workbench.
  5. HyperVolume results in a DeprecationWarning being logged. It is better to calculate hypervolume in post. This also closes Docs: Expand on HyperVolume minimum and maximum parameters #149
  6. modifications to various init files to ensure the correct functions and classes can be directly imported from ema_workbench.

this pull request needs to be merged before we can resolve issue #147

@quaquel quaquel requested a review from EwoutH October 12, 2022 19:26
@quaquel quaquel added this to the 2.3.0 milestone Oct 12, 2022
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 12, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 81.139% when pulling 5f8274d on convergence_tracking into 3f60527 on master.

@quaquel quaquel force-pushed the convergence_tracking branch from a91f4b7 to 1c824f7 Compare October 12, 2022 19:33
@EwoutH
Copy link
Copy Markdown
Collaborator

EwoutH commented Oct 12, 2022

Looks like an major effort! I will dive into this tomorrow.

@quaquel quaquel mentioned this pull request Oct 13, 2022
Merged
@review-notebook-app
Copy link
Copy Markdown

review-notebook-app bot commented Oct 19, 2022

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

EwoutH
EwoutH approved these changes Oct 19, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two last nick picks, when those are resolved it's good to go!

@quaquel
Copy link
Copy Markdown
Owner Author

quaquel commented Oct 19, 2022

Two last nick picks, when those are resolved it's good to go!

A nice use case for the walrus operator indeed. I had completely. forgetting about it while writing the code.

EwoutH
EwoutH reviewed Oct 19, 2022
View reviewed changes
@EwoutH EwoutH merged commit 60a45e7 into master Oct 19, 2022
@EwoutH
Copy link
Copy Markdown
Collaborator

EwoutH commented Oct 19, 2022

I checked the Read the Docs and found a few missing empty lines in the docstring, fixed those in 5f8274d, and merged!

Congratulations on getting this major feature in!

quaquel added a commit that referenced this pull request Oct 25, 2022
@quaquel
Improved directed search tutorial (#194)
76dcc45 
Building on #193, this substantially expands the directed search tutorial with improved discussion on convergence, seed analysis, and robust optimization. In addition, various links to relevant literature have been added.
@quaquel quaquel deleted the convergence_tracking branch October 28, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EwoutH EwoutH EwoutH approved these changes

Assignees

No one assigned

Labels

enhancement feature

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

convergence tracking of optimization Docs: Expand on HyperVolume minimum and maximum parameters

3 participants

@quaquel @coveralls @EwoutH