Conversation
Collaborator
|
Nice work, I will take an in depth look after #170 is merged. Please try to keep PRs to one single subject by the way, that makes both reviewing easier and bugs are easier traced back, especially as time passes. I must say, we are making quite some progress in only a few weeks! |
resolves #148 Outcomes are now stored in masked arrays. If get_results is called and there are no masked entries left (i.e., all experiments completed successfully), the arrays are unmasked. Otherwise, masked arrays are returned and a warning is logged. This commit also does some more refactoring of callback.py, adds some unit tests, and does a bit of cleaning. Co-Authored-By: Jan Kwakkel <[email protected]>
EwoutH
force-pushed
the
masked_arrays
branch
from
0649113 to
db5aca4
Compare
EwoutH
reviewed
Sep 24, 2022
Collaborator
EwoutH
left a comment
EwoutH
left a comment
There was a problem hiding this comment.
Looks great overall! I added a few nitpicks.
Co-authored-by: Ewout ter Hoeven <[email protected]>
Owner
Author
|
should be ready now to be merged |
Collaborator
|
It's in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #148
Outcomes are now stored in masked arrays. If get_results is called and there are no masked entries left (i.e., all experiments completed successfully), the arrays are unmasked. Otherwise, masked arrays are returned and a warning is logged.
this PR also does some more refactoring of callback.py, adds some unit tests, and does a bit of cleaning.