Skip to content

set scikit-learn requirement >= 1.0.0#144

Merged
quaquel merged 1 commit intoquaquel:masterfrom
rhysits:scikit-learn-requirement
Jun 9, 2022
Merged

set scikit-learn requirement >= 1.0.0#144
quaquel merged 1 commit intoquaquel:masterfrom
rhysits:scikit-learn-requirement

Conversation

@rhysits
Copy link
Copy Markdown
Contributor

@rhysits rhysits commented Jun 9, 2022

criterion = "squared_error" was introduced in scikit-learn v1.0, so feature_scoring.py can run into KeyError: 'squared_error' when an earlier version is used. This commit updates requirements.txt to force scikit-learn >= 1.0.0

criterion = "squared_error" was introduced in scikit-learn v1.0, so feature_scoring.py can run into errors when an earlier version of scikit-learn is used
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 80.04% when pulling de943cc on rhysits:scikit-learn-requirement into f718982 on quaquel:master.

@quaquel quaquel merged commit 1b5175d into quaquel:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants