feature_scoring.py: Change max_features in get_rf_feature_scores to "sqrt"#129
Merged
quaquel merged 1 commit intoquaquel:masterfrom May 18, 2022
Merged
feature_scoring.py: Change max_features in get_rf_feature_scores to "sqrt"#129quaquel merged 1 commit intoquaquel:masterfrom
max_features in get_rf_feature_scores to "sqrt"#129quaquel merged 1 commit intoquaquel:masterfrom
Conversation
…sqrt" The usage of max_features="auto" as parameter value in RandomForestRegressors and ExtraTreesRegressors is depreciated in scikit-learn 1.1 and will be removed in 1.3. The default value for max_features also changed from from "auto" to "sqrt" in version 1.1. This commit changes max_features parameter to "sqrt". Behaviour should be identical. Note that this value can also be removed, since the default value is also "sqrt".
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usage of
max_features="auto"as parameter value in RandomForestRegressors and ExtraTreesRegressors is depreciated in scikit-learn 1.1 and will be removed in 1.3. The default value formax_featuresalso changed from from"auto"to"sqrt"in version 1.1.This commit changes
max_featuresparameter to"sqrt". Behaviour should be identical. Note that this value can also be removed, since the default value is also"sqrt".Closes #127.