Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: quaquel/EMAworkbench
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.2.0
Choose a base ref
...
head repository: quaquel/EMAworkbench
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.2.1
Choose a head ref
  • 5 commits
  • 6 files changed
  • 2 contributors

Commits on Oct 6, 2022

  1. Switch to using format string in prim logging (#161) 

    The main purpose is to fix #155 but I used this as an excuse to modify other logging message to switch to using format strings as well
    @quaquel @EwoutH
    quaquel authored and EwoutH committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    80cc855 View commit details
    Browse the repository at this point in the history

  2. Fix n-dimensional output bug in Netlogo connector 

    Fixes #168.

An ArrayOutcome is for any n-dimensional results. TimeSeriesOutcome subclasses ArrayOutcome and will receive at some point a meaningful index and most likely become a dataframe.
    @quaquel @EwoutH
    quaquel authored and EwoutH committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    c88202e View commit details
    Browse the repository at this point in the history

  3. Update to outcomes documentation (#183) 

    Resolves the documentation part of #168
    @quaquel @EwoutH
    quaquel authored and EwoutH committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    aa262e4 View commit details
    Browse the repository at this point in the history

  4. Fix negative input for n_processes in MultiprocessingEvaluator (#189) 

    PR #140 introduced a feature for the MultiprocessingEvaluator to take a negative input for n_processes, which initialize the evaluator with the cpu_count minus that negative integer, leaving that number of cores free.

In 7dd1610 this code was refactored, introducing a bug that broke the negative-integer input functionality. When a negative integer is inputted, a AttributeError: 'MultiprocessingEvaluator' object has no attribute 'n_processes' was created.

The bug was caused by self.n_processes begin used instead of n_processes, where in earlier code self.n_processes was set equal to n_processes earlier in the process.

This commit fixes this behaviour by using n_processes to calculate self.n_processes.
    @EwoutH
    EwoutH committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    0b78c7a View commit details
    Browse the repository at this point in the history

  5. Update changelog and bump version for 2.2.1 release

    @EwoutH
    EwoutH committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    dd175e1 View commit details
    Browse the repository at this point in the history
Loading