Serialize tags on moments in cirq_google protos #7493
Conversation
dstrain115
commented
Jul 15, 2025
dstrain115
commented
- Tags were added to Moments this month.
- Adds the ability to serialize tags on Moments using cirq_google protos.
- Tags were added to Moments this month. - Adds the ability to serialize tags on Moments using cirq_google protos.
dstrain115
requested review from
a team,
verult,
vtomole and
wcourtney
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7493 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 1091 1091
Lines 96853 96865 +12
=======================================
+ Hits 95575 95590 +15
+ Misses 1278 1275 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
The DiscountTag does not make it through the serde loop. Otherwise LGTM.
|
|
||
| for tag in moment.tags: | ||
| self._serialize_tag( | ||
| tag, moment_proto, constants=constants, raw_constants=raw_constants |
There was a problem hiding this comment.
nit - please update type annotation for the msg argument of _serialize_tag.
| cirq.Moment(cirq.Z(cirq.GridQubit(2, 2))).with_tags(cg.CalibrationTag("abc")), | ||
| ) | ||
| deserialized_circuit = serializer.deserialize(serializer.serialize(original_circuit)) | ||
| assert original_circuit == deserialized_circuit |
There was a problem hiding this comment.
Somehow the DiscountTag does not appear in deserialized_circuit[0].tags. Please add an explicit checks for the expected moment tags. Moment.__eq__ seems to compare only the operations.
There was a problem hiding this comment.
Oh, that's a very good call! Nice reviewing!
I added the checks. I forgot that the DiscountTag needs a custom serializer. Fixed.
2 participants
