Skip to content

Remove dead code for scipy<=1.5 #7410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pavoljuhas merged 1 commit into from
Jun 4, 2025
Merged

Remove dead code for scipy<=1.5 #7410

pavoljuhas merged 1 commit into from
Jun 4, 2025

Conversation

@pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Jun 4, 2025

We require scipy>=1.11 so any special code for earlier scipy is dead.

@pavoljuhas
Remove dead code for scipy<=1.5
380f622 
We require scipy>=1.11 so it is obsolete.
@github-actions github-actions bot added the size: S 10< lines changed <50 label Jun 4, 2025
@pavoljuhas pavoljuhas marked this pull request as ready for review June 4, 2025 20:35
@pavoljuhas pavoljuhas requested review from a team and vtomole as code owners June 4, 2025 20:35
@pavoljuhas pavoljuhas requested review from mhucka and tanujkhattar June 4, 2025 20:35
@codecov
Copy link

codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (d1d25f8) to head (380f622).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7410      +/-   ##
==========================================
- Coverage   98.69%   98.69%   -0.01%     
==========================================
  Files        1112     1112              
  Lines       97754    97748       -6     
==========================================
- Hits        96477    96468       -9     
- Misses       1277     1280       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mhucka
mhucka approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas added this pull request to the merge queue Jun 4, 2025
Merged via the queue into quantumlib:main with commit 4b118d0 Jun 4, 2025
35 checks passed
@pavoljuhas pavoljuhas deleted the purge-code-for-old-scipy branch June 4, 2025 22:51
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
@pavoljuhas @BichengYing
Remove dead code for scipy<=1.5 (quantumlib#7410)
034a425 
We require scipy>=1.11 so any special code for earlier scipy is dead.
This was referenced Aug 5, 2025
Closed
Merged
@NoureldinYosri NoureldinYosri mentioned this pull request Sep 11, 2025
Merged
@NoureldinYosri NoureldinYosri mentioned this pull request Sep 25, 2025
Merged
@NoureldinYosri NoureldinYosri mentioned this pull request Oct 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhucka mhucka mhucka approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@tanujkhattar tanujkhattar Awaiting requested review from tanujkhattar tanujkhattar is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees

No one assigned

Labels

size: S 10< lines changed <50

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavoljuhas @mhucka