-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Prefer load_device_noise_properties in example notebooks #7408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace use of noise_properties_from_calibration for more convenience with gate_times_ns argument.
Add those notebooks to `NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7408 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 1112 1112
Lines 97755 97755
=======================================
Hits 96472 96472
Misses 1283 1283 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mhucka
approved these changes
Jun 3, 2025
Contributor
mhucka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dstrain115
approved these changes
Jun 3, 2025
babacry
pushed a commit
to babacry/Cirq
that referenced
this pull request
Jun 4, 2025
…7408) Replace calls of `noise_properties_from_calibration` with `load_device_noise_properties` so users do not need to pass the `gate_times_ns` argument. Updated notebooks need to install development cirq and be listed in `NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES`. Related to b/395705720
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
…7408) Replace calls of `noise_properties_from_calibration` with `load_device_noise_properties` so users do not need to pass the `gate_times_ns` argument. Updated notebooks need to install development cirq and be listed in `NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES`. Related to b/395705720
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace calls of
noise_properties_from_calibrationwithload_device_noise_propertiesso users do not need to passthe
gate_times_nsargument.Updated notebooks need to install development cirq and be listed in
NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES.Related to b/395705720