Skip to content

Conversation

@pavoljuhas
Copy link
Collaborator

Replace calls of noise_properties_from_calibration with
load_device_noise_properties so users do not need to pass
the gate_times_ns argument.

Updated notebooks need to install development cirq and be listed in
NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES.

Related to b/395705720

Replace use of noise_properties_from_calibration for more convenience
with gate_times_ns argument.
Add those notebooks to `NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES`.
@pavoljuhas pavoljuhas requested review from a team and vtomole as code owners June 3, 2025 01:11
@pavoljuhas pavoljuhas requested a review from viathor June 3, 2025 01:11
@github-actions github-actions bot added the size: M 50< lines changed <250 label Jun 3, 2025
@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (fa8d64d) to head (67beef7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7408   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files        1112     1112           
  Lines       97755    97755           
=======================================
  Hits        96472    96472           
  Misses       1283     1283           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas added this pull request to the merge queue Jun 3, 2025
Merged via the queue into quantumlib:main with commit 1f17390 Jun 3, 2025
35 checks passed
@pavoljuhas pavoljuhas deleted the qvm-update-notebooks branch June 3, 2025 05:04
babacry pushed a commit to babacry/Cirq that referenced this pull request Jun 4, 2025
…7408)

Replace calls of `noise_properties_from_calibration` with
`load_device_noise_properties` so users do not need to pass
the `gate_times_ns` argument.

Updated notebooks need to install development cirq and be listed in
`NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES`.

Related to b/395705720
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
…7408)

Replace calls of `noise_properties_from_calibration` with
`load_device_noise_properties` so users do not need to pass
the `gate_times_ns` argument.

Updated notebooks need to install development cirq and be listed in
`NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES`.

Related to b/395705720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants