Add QVM factory function load_device_noise_properties #7369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convenience function for constructing GoogleNoiseProperties from available specifications for known QVM device. Related to b/395705720
pavoljuhas
requested review from
a team,
verult,
vtomole and
wcourtney
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7369 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 1112 1112
Lines 97588 97601 +13
=======================================
+ Hits 96307 96320 +13
Misses 1281 1281 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eliottrosenberg
approved these changes
May 23, 2025
Collaborator
eliottrosenberg
left a comment
eliottrosenberg
left a comment
There was a problem hiding this comment.
Thanks, @pavoljuhas!
dstrain115
approved these changes
May 23, 2025
| the Z phases data, if available, to construct NoiseProperties for device simulation. | ||
| Args: | ||
| processor_id: name of the processor to simulate. |
Collaborator
There was a problem hiding this comment.
Should we either specify valid processor names or tell where to find them?
Collaborator
Author
There was a problem hiding this comment.
Good point, there seems to be no public API to get those names apart from reading the code. I will add a list_virtual_processors function in next PR.
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
May 27, 2025
Convenience function to get the valid `processor_id` strings for QVM factories. Follow-up to quantumlib#7369
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 27, 2025
Convenience function to get the valid `processor_id` strings for QVM factories. Follow-up to #7369
This was referenced May 30, 2025
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
Convenience function for constructing GoogleNoiseProperties from available specifications for known QVM devices. Related to b/395705720
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
…#7375) Convenience function to get the valid `processor_id` strings for QVM factories. Follow-up to quantumlib#7369
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convenience function for constructing GoogleNoiseProperties from available
specifications for known QVM devices.
Related to b/395705720