Add bytes to cirq_google proto #7201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Mar 31, 2025
dstrain115
commented
- Adds bytes to the cirq_google Arg proto
- Adds hooks in arg_func_langs to serialize and deserialize it.
- Adds bytes to the cirq_google Arg proto - Adds hooks in arg_func_langs to serialize and deserialize it.
dstrain115
requested review from
a team,
verult,
vtomole and
wcourtney
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7201 +/- ##
==========================================
- Coverage 98.14% 98.14% -0.01%
==========================================
Files 1100 1100
Lines 96147 96244 +97
==========================================
+ Hits 94365 94458 +93
- Misses 1782 1786 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
approved these changes
Mar 31, 2025
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
Please see comments before merging.
| if which_val == 'value_with_unit': | ||
| return tunits.Value.from_proto(arg_value.value_with_unit) | ||
| if which_val == 'bytes_value': | ||
| return bytes(arg_value.bytes_value) |
Collaborator
There was a problem hiding this comment.
Note (no change necessary) - perhaps these iffs could be converted to a match-case block.
Collaborator
Author
There was a problem hiding this comment.
SGTM, maybe in a follow-up PR.
| (1.0, {'arg_value': {'float_value': 1.0}}), | ||
| (1, {'arg_value': {'float_value': 1.0}}), | ||
| ( | ||
| bytes('abcdef', 'utf-8'), |
Collaborator
There was a problem hiding this comment.
Nit - consider replacing bytes('abcdef', 'utf-8') --> b'abcdef'
This was referenced May 30, 2025
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
* Add bytes to cirq_google proto - Adds bytes to the cirq_google Arg proto - Adds hooks in arg_func_langs to serialize and deserialize it. * Changed bytes to b
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.