Skip to content

Conversation

@pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Feb 1, 2025

  • Enable Contract-a-Grid-Circuit.ipynb quimb notebook
  • Test it with a smaller grid circuit to prevent OOM on GitHub actions

Fixes #6590

@CirqBot CirqBot added the Size: XS <10 lines changed label Feb 1, 2025
@codecov
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.89%. Comparing base (5e8466b) to head (fcd84be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7015   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files        1085     1085           
  Lines       95132    95132           
=======================================
+ Hits        93126    93127    +1     
+ Misses       2006     2005    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas
Copy link
Collaborator Author

Intentional failure from b427c59 shows up at

  • Continuous Integration / Notebook Tests against PR
  • Continuous Integration - Daily / Pytest MacOS (3.X)
  • Continuous Integration - Daily / Pytest Ubuntu (3.X)

@CirqBot CirqBot added the size: L 250< lines changed <1000 label Feb 1, 2025
@pavoljuhas pavoljuhas force-pushed the enable-contract-a-grid-notebook branch from d1de8ae to fcd84be Compare February 1, 2025 03:35
@pavoljuhas pavoljuhas marked this pull request as ready for review February 1, 2025 03:36
@pavoljuhas pavoljuhas requested review from a team and vtomole as code owners February 1, 2025 03:36
@pavoljuhas pavoljuhas requested review from dabacon and mhucka February 1, 2025 03:36
@pavoljuhas pavoljuhas enabled auto-merge February 1, 2025 03:41
Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good to see another old issue fixed!

@pavoljuhas pavoljuhas added this pull request to the merge queue Feb 1, 2025
Merged via the queue into quantumlib:main with commit 0e5db12 Feb 1, 2025
38 checks passed
@pavoljuhas pavoljuhas deleted the enable-contract-a-grid-notebook branch February 1, 2025 04:09
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
…#7015)

* Enable Contract-a-Grid-Circuit.ipynb quimb-dependent notebook

* Test notebook with a smaller circuit to prevent OOM on GitHub actions

Fixes quantumlib#6590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: L 250< lines changed <1000 Size: XS <10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix CI failure of Contract-a-Grid-Circuit.ipynb on Python 3.12

3 participants