Fix check/nbformat installation and execution #7004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7004 +/- ##
==========================================
- Coverage 97.89% 97.89% -0.01%
==========================================
Files 1085 1085
Lines 95098 95098
==========================================
- Hits 93096 93094 -2
- Misses 2002 2004 +2 ☔ View full report in Codecov by Sentry. |
- Fail early if tensorflow-docs installation is broken. - Use exit status from the nbfmt tool to decide if the format is good.
Executed check/nbformat --apply
pavoljuhas
force-pushed
the
fix-check_nbformat-script
branch
from
3eaae6c to
2008a73
Compare
pavoljuhas
requested review from
a team,
ma5x,
mrwojtek,
pschindler,
verult,
vtomole and
wcourtney
as code owners
mhucka
pushed a commit
to mhucka/Cirq
that referenced
this pull request
Jan 30, 2025
* Improve the check/nbformat script - Fail early if tensorflow-docs installation is broken. - Use exit status from the nbfmt tool to decide if the format is good. * Bump up tensorflow-docs to be compatible with protobuf-4 * Format jupyter notebooks Executed check/nbformat --apply
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
* Improve the check/nbformat script - Fail early if tensorflow-docs installation is broken. - Use exit status from the nbfmt tool to decide if the format is good. * Bump up tensorflow-docs to be compatible with protobuf-4 * Format jupyter notebooks Executed check/nbformat --apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7002