Fix ci-daily notebook failures on Mac OS X #6444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ci-daily failure on Mac due to incompatible versions of quimb and numba.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6444 +/- ##
==========================================
- Coverage 97.81% 97.81% -0.01%
==========================================
Files 1111 1111
Lines 97198 97198
==========================================
- Hits 95078 95074 -4
- Misses 2120 2124 +4 ☔ View full report in Codecov by Sentry. |
This reverts commit ea056b7.
NoureldinYosri
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use common version specification for quimb and numba as defined in
contrib/requirements.txt. And install notebook dependencies for all CI platforms.
Avoid incompatible versions of quimb and numba in notebook environments.
Example failure: https://github.com/quantumlib/Cirq/actions/runs/7792626671/job/21250976788#step:6:580
Fix verified at https://github.com/quantumlib/Cirq/actions/runs/7805446772
Related to #6336