Change default for streaming feature flag to false #6310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verult
requested review from
a team,
cduck,
vtomole and
wcourtney
as code owners
pavoljuhas
approved these changes
Oct 4, 2023
…t/feature-gate-off
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6310 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 1108 1108
Lines 96398 96398
=======================================
Hits 94317 94317
Misses 2081 2081
☔ View full report in Codecov by Sentry. |
verult
added a commit
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to be merged only in exceptional situations as a way to quickly turn the streaming feature off, e.g. when the feature misbehaves.