Apply variable-spaced optimization to QROM circuits #6257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdmalone
reviewed
Aug 23, 2023
fdmalone
reviewed
Aug 23, 2023
fdmalone
reviewed
Aug 23, 2023
fdmalone
requested changes
Aug 23, 2023
Contributor
fdmalone
left a comment
fdmalone
left a comment
There was a problem hiding this comment.
LGTM % adding an additional test case.
Collaborator
Author
|
@fdmalone Added more tests and also updated the |
fdmalone
approved these changes
Aug 23, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6257 +/- ##
==========================================
- Coverage 97.60% 97.60% -0.01%
==========================================
Files 1116 1116
Lines 95772 95815 +43
==========================================
+ Hits 93481 93519 +38
- Misses 2291 2296 +5
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the unary iteration framework to allow "early termination" and uses this trick to apply the variable-spacing optimization to QROM circuits described in https://arxiv.org/pdf/2007.07391.pdf
As a drive-by fix, the PR also fixes a flaky bug in
GreedyQubitManagerwhere the free'd qubits were added to the pool of managed qubits in a non-deterministic order due to finding unique elements viaset(qubits). Replaced with an order-preserving way of finding unique elements.