Skip to content

Generalize filtration of dev requirements that can't be uploaded to pypi #5886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vtomole merged 2 commits into from
Sep 21, 2022
Merged

Generalize filtration of dev requirements that can't be uploaded to pypi #5886

vtomole merged 2 commits into from
Sep 21, 2022

Conversation

@vtomole
Copy link
Collaborator

@vtomole vtomole commented Sep 21, 2022

Fixes: #5880

@vtomole vtomole requested review from a team and cduck as code owners September 21, 2022 15:17
@vtomole vtomole requested a review from viathor September 21, 2022 15:17
@CirqBot CirqBot added the Size: XS <10 lines changed label Sep 21, 2022
@vtomole vtomole mentioned this pull request Sep 21, 2022
Closed
@vtomole vtomole requested a review from pavoljuhas September 21, 2022 15:19
@vtomole vtomole changed the title Generalize dev requirements that don't need to be uploaded because of prevention of uploading non-Pypi packaes Generalize dev requirements that don't need to be uploaded because of prevention of uploading non-Pypi packages Sep 21, 2022
@vtomole vtomole changed the title Generalize dev requirements that don't need to be uploaded because of prevention of uploading non-Pypi packages Generalize filtration of dev requirements that can't be uploaded to pypi Sep 21, 2022
maffoo
maffoo reviewed Sep 21, 2022
View reviewed changes
setup.py Outdated

# filter out direct urls (https://github.com/pypa/pip/issues/6301)
dev_requirements = [r.strip() for r in dev_requirements if "git+http" not in r]
dev_requirements = [r.strip() for r in dev_requirements if "http" not in r]
Copy link
Contributor

@maffoo maffoo Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to do something like https:// to be sure this catches urls only, since a standard pypi package could include the string "http".

Copy link
Collaborator Author

@vtomole vtomole Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

pavoljuhas
pavoljuhas approved these changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vtomole vtomole merged commit ce8d19f into master Sep 21, 2022
@vtomole vtomole deleted the vtomole-patch-2 branch September 21, 2022 16:43
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@vtomole @rht
Generalize filtration of dev requirements that can't be uploaded to p…
d58ce6a 
…ypi (quantumlib#5886)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maffoo maffoo maffoo left review comments

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@cduck cduck Awaiting requested review from cduck

@viathor viathor Awaiting requested review from viathor viathor was automatically assigned from quantumlib/cirq-maintainers

Assignees

No one assigned

Labels

Size: XS <10 lines changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MacOS checks failing

4 participants

@vtomole @maffoo @pavoljuhas @CirqBot