Remove id from top-level notebook structure.
#5874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nbformat` currently barfs on this notebook as it has an `id` field set directly on the cell. They're expected under a `metadata` field, and this notebook already has them set on the metadata, so assuming they're otherwise unused I have removed them.
Here's the error, in case it helps:
```
E 2022-09-08 20:30:15.962852-070026 57758 __init__.py:80 Notebook JSON is invalid: Additional properties are not allowed ('id' was unexpected)
Failed validating 'additionalProperties' in code_cell:
On instance['cells'][0]:
{'cell_type': 'code',
'execution_count': 1,
'id': 'ee22a795',
'metadata': {'cellView': 'form',
'execution': {'iopub.execute_input': '2022-07-07T09:27:05.420016Z',
'iopub.status.busy': '2022-07-07T09:27:05.419434Z',
'iopub.status.idle': '2022-07-07T09:27:05.423857Z',
'shell.execute_reply': '2022-07-07T09:27:05.423255Z'},
'id': '906e07f6e562'},
'outputs': ['...0 outputs...'],
'source': '# @title Copyright 2022 The Cirq Developers\n'
'# Licensed under the...'}
```
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
Author
|
Failed Pytest looks like differences in floating point rounding, I'm guessing unrelated to this change? |
Collaborator
|
@markmcd What did you run to get this error? This passes on the |
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
`nbformat` currently barfs on this notebook as it has an `id` field set directly on the cell. They're expected under a `metadata` field, and this notebook already has them set on the metadata, so assuming they're otherwise unused I have removed them.
Here's the error, in case it helps:
```
E 2022-09-08 20:30:15.962852-070026 57758 __init__.py:80 Notebook JSON is invalid: Additional properties are not allowed ('id' was unexpected)
Failed validating 'additionalProperties' in code_cell:
On instance['cells'][0]:
{'cell_type': 'code',
'execution_count': 1,
'id': 'ee22a795',
'metadata': {'cellView': 'form',
'execution': {'iopub.execute_input': '2022-07-07T09:27:05.420016Z',
'iopub.status.busy': '2022-07-07T09:27:05.419434Z',
'iopub.status.idle': '2022-07-07T09:27:05.423857Z',
'shell.execute_reply': '2022-07-07T09:27:05.423255Z'},
'id': '906e07f6e562'},
'outputs': ['...0 outputs...'],
'source': '# @title Copyright 2022 The Cirq Developers\n'
'# Licensed under the...'}
```
Co-authored-by: Victory Omole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nbformatcurrently barfs on this notebook as it has anidfield set directly on the cell. They're expected under ametadatafield, and this notebook already has them set on the metadata, so assuming they're otherwise unused I have removed them.Here's the error, in case it helps: