Skip to content

Fix the definition of PhasedFSimGate #5736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CirqBot merged 4 commits into from
Jul 12, 2022
Merged

Fix the definition of PhasedFSimGate #5736

CirqBot merged 4 commits into from
Jul 12, 2022

Conversation

@eliottrosenberg
Copy link
Collaborator

@eliottrosenberg eliottrosenberg commented Jul 12, 2022

The \theta dependence was missing from lines 224-225

@eliottrosenberg
Fix the definition of PhasedFSimGate
3eda2ef 
The \theta dependence was missing from lines 224-225
@eliottrosenberg eliottrosenberg requested review from a team, cduck and vtomole as code owners July 12, 2022 17:25
@eliottrosenberg eliottrosenberg requested a review from maffoo July 12, 2022 17:25
@google-cla
Copy link

google-cla bot commented Jul 12, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@CirqBot CirqBot added the Size: XS <10 lines changed label Jul 12, 2022
@eliottrosenberg
Copy link
Collaborator Author

eliottrosenberg commented Jul 12, 2022 •
edited
Loading

For comparison, see these pages, which have definitions of the PhasedFSimGate:
https://quantumai.google/cirq/noise/calibration_api
https://quantumai.google/cirq/noise/qcvv/xeb_coherent_noise

maffoo
maffoo approved these changes Jul 12, 2022
View reviewed changes
dabacon
dabacon approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this was my barf during a LaTeXification of the gates. Thanks for fixing.

@dabacon dabacon added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 12, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 12, 2022
@CirqBot CirqBot merged commit e85c80f into quantumlib:master Jul 12, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 12, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@eliottrosenberg @rht
Fix the definition of PhasedFSimGate (quantumlib#5736)
0693747 
The \theta dependence was missing from lines 224-225
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@eliottrosenberg
Fix the definition of PhasedFSimGate (quantumlib#5736)
d631f39 
The \theta dependence was missing from lines 224-225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dabacon dabacon dabacon approved these changes

@maffoo maffoo maffoo approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

Assignees

No one assigned

Labels

Size: XS <10 lines changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eliottrosenberg @dabacon @maffoo @CirqBot