Skip to content

Nitpick on comment after #5724 #5732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CirqBot merged 3 commits into from
Jul 12, 2022
Merged

Nitpick on comment after #5724 #5732

CirqBot merged 3 commits into from
Jul 12, 2022

Conversation

@pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Jul 12, 2022 •
edited
Loading

Avoid head scratching over a reference to method removed in #5724.

@pavoljuhas
Fix obsolete comment
48f8558 
Avoid head scratching over non-existent method name.
@pavoljuhas pavoljuhas requested review from a team, cduck and vtomole as code owners July 12, 2022 05:15
@pavoljuhas pavoljuhas requested a review from mpharrigan July 12, 2022 05:15
@CirqBot CirqBot added the Size: XS <10 lines changed label Jul 12, 2022
@dabacon dabacon added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 12, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 12, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Jul 12, 2022

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 12, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 12, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 12, 2022
@CirqBot CirqBot merged commit b8bb277 into quantumlib:master Jul 12, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 12, 2022
@pavoljuhas pavoljuhas deleted the nit-comment-after-5724 branch July 12, 2022 16:52
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@pavoljuhas @rht
Nitpick on comment after quantumlib#5724 (quantumlib#5732)
9568582 
Avoid head scratching over a reference to method removed in quantumlib#5724.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@pavoljuhas
Nitpick on comment after quantumlib#5724 (quantumlib#5732)
fe3285c 
Avoid head scratching over a reference to method removed in quantumlib#5724.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dabacon dabacon dabacon approved these changes

@dstrain115 dstrain115 dstrain115 approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@mpharrigan mpharrigan Awaiting requested review from mpharrigan mpharrigan was automatically assigned from quantumlib/cirq-maintainers

@MichaelBroughton MichaelBroughton Awaiting requested review from MichaelBroughton

Assignees

No one assigned

Labels

Size: XS <10 lines changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pavoljuhas @CirqBot @dabacon @dstrain115 @MichaelBroughton