Add json serialization to sweeps #5618
Conversation
95-martin-orion
left a comment
95-martin-orion
left a comment
There was a problem hiding this comment.
LGTM (% one concern, below). What is the expected use case for this?
| def __repr__(self) -> str: | ||
| return 'cirq.UnitSweep' | ||
|
|
||
| def _json_dict_(self) -> Dict[str, Any]: |
There was a problem hiding this comment.
Based on the name, _Unit is a private class. Do we want it to be serializable?
If so, I think this needs a _from_json_dict_ classmethod.
There was a problem hiding this comment.
This ends up being necessary in order to serialize UnitSweep. This is similar, I think to the Pauli singletons. My criteria was that with this PR it should serialize and deserialize cirq.UnitSweep correctly (should be UNIT_SWEEP btw), which it does. I think you can also use it to serialize and deserialize _Unit by going in and grabbing that class explicitly, but I don't know a way to stop this for this singleton pattern.
There was a problem hiding this comment.
SGTM. This can merge once the tests are sorted out.
|
Use case is that objects that set our context for experiments should be serializable. |
|
Ugh bad merge fixing |
dabacon
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage'] |
CirqBot
removed
automerge
dabacon
added
the
automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Coverage check', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage'] |
CirqBot
removed
the
automerge
dabacon
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Adds missing json serialization for sweep objects.
Adds missing json serialization for sweep objects.
3 participants
Adds missing json serialization for sweep objects.