IonQ: Handle 409 errors that are injected by Cloudflare #5292
Conversation
Cynocracy
requested review from
a team,
ColemanCollins,
cduck,
dabacon,
gmauricio,
nakardo and
vtomole
as code owners
dabacon
left a comment
dabacon
left a comment
There was a problem hiding this comment.
An excellent job not selling me on cloudfare.
|
I do my best ;) These errors are hopefully going away, but we're pretty set on not returning 409s ourselves on GETs, so ty for the review! |
Cynocracy
force-pushed
the
cloudflare-what-the-heck
branch
from
aecdc29 to
4f05fbd
Compare
|
Revived this zombie PR 🧟 |
Cynocracy
force-pushed
the
cloudflare-what-the-heck
branch
from
5db3bcd to
6474575
Compare
|
test appears to have flaked |
|
Are the typescript tests just busted? (also there's typescript now? 😮 ) |
|
@Cynocracy I have a fix here: #6014 |
|
Thanks Victory! This was actually a separate PR, was just noting the test failures |
|
Reopening and updating from master; per jon the flaky tests were causing this to not be ready to merge but the underlying failure around cloudflare fronting the IonQ API still needs to be addressed |
| response2.ok = True | ||
| response2.json.return_value = {'foo': 'bar'} | ||
|
|
||
| client = ionq.ionq_client._IonQClient(remote_host='http://example.com', api_key='to_my_heart') |
There was a problem hiding this comment.
@dabacon @Cynocracy I still love the dummy API key we use for these tests
There was a problem hiding this comment.
lol, it's pretty great
6 participants
When these occur on GETs, they can be retried.