Repository navigation
test(spark): check struct nulls through the pruned read - #32
Merged
Merged
Conversation
The null checks in VortexNestedSchemaPruningTest selected IS NULL on its own, so Spark read the whole struct and never exercised the pruned projection. Select the null checks next to a pruned field, so the scan reads the pruned struct, and assert the read schema to keep it that way. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Christopher Wirt <[email protected]>
gitRasheed
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #10, from its code review.
The
IS NULLchecks inVortexNestedSchemaPruningTestnever exercised the pruned read. On its own,n IS NULLmakes Spark read the wholen, so dropping struct nulls in the pruned projection went unnoticed.Changes
Checked by removing the
maskinNestedSchemaPruning:nullableStructInStructFieldnow fails, where before no test did.Tested with:
./gradlew spotlessCheck :vortex-spark_2.13:test :vortex-spark_2.12:test: all pass🤖 Generated with Claude Code