test: remove unnecessary target exclusions from RevisionInfo#1093
Merged
quic-seaswara merged 1 commit intoqualcomm:mainfrom Apr 23, 2026
Merged
Conversation
Contributor
|
Welcome to eld! This change looks good to me. One small note: our commit messages typically use a bracketed prefix: |
zeel2104
force-pushed
the
fix-revisioninfo-target-support
branch
2 times, most recently
from
a46f863 to
1574775
Compare
quic-seaswara
approved these changes
Apr 22, 2026
Signed-off-by: Zeel <[email protected]>
quic-seaswara
force-pushed
the
fix-revisioninfo-target-support
branch
from
1574775 to
2bf3f90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unnecessary
UNSUPPORTEDline fromtest/Common/standalone/Map/RevisionInfo/RevisionInfo.s.This test only assembles a simple
nopand checks linker/LLVM revisioninformation in the generated map file, so it does not need to be excluded for
arm,aarch64,riscv32, orriscv64.Testing
Attempted targeted test runs with:
python D:\obj\tools\eld\test\llvm-lit-arm-default -a D:\llvm-project\eld\test\Common\standalone\Map\RevisionInfo\RevisionInfo.spython D:\obj\tools\eld\test\llvm-lit-aarch64-default -a D:\llvm-project\eld\test\Common\standalone\Map\RevisionInfo\RevisionInfo.spython D:\obj\tools\eld\test\llvm-lit-riscv64-default -a D:\llvm-project\eld\test\Common\standalone\Map\RevisionInfo\RevisionInfo.sIn this local Windows environment, lit fails before test execution due to a
test harness path issue in
/bin/bashwhen invoking the generated.scriptfile, so the local runs are inconclusive.