Skip to content

Commit ded504c

Browse files
committed
minor refactoring
Signed-off-by: ceki <[email protected]>
1 parent 8af5459 commit ded504c

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

logback-core/src/main/java/ch/qos/logback/core/util/VersionUtil.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -182,14 +182,12 @@ static public void checkForVersionEquality(Context context, String dependentVers
182182
// the dependent depends on the dependency
183183
addFoundVersionStatus(context, dependentName, dependentVersion);
184184

185-
if(dependencyVersion == null) {
186-
String nullDependencyVersion = String.format("Failed to find version for %s.", dependencyName);
187-
context.getStatusManager().add(new WarnStatus(nullDependencyVersion, context));
188-
return;
189-
}
185+
dependentVersion = nonNull(dependentVersion);
186+
187+
190188
if (dependentVersion.equals(NA) || !dependentVersion.equals(dependencyVersion)) {
191189
addFoundVersionStatus(context, dependencyName, dependencyVersion);
192-
String discrepancyMsg = String.format("Versions of %s and %s are different!", dependencyName, dependentName);
190+
String discrepancyMsg = String.format("Versions of %s and %s are different or unknown.", dependencyName, dependentName);
193191
context.getStatusManager().add(new WarnStatus(discrepancyMsg, context));
194192
}
195193
}
@@ -199,7 +197,7 @@ static public void checkForVersionEquality(Context context, String dependentVers
199197

200198

201199
private static void addFoundVersionStatus(Context context, String name, String version) {
202-
String foundDependent = String.format("Found %s version %s", name, version);
200+
String foundDependent = String.format("Found %s version %s", name, nonNull(version));
203201
context.getStatusManager().add(new InfoStatus(foundDependent, context));
204202
}
205203

0 commit comments

Comments
 (0)