modify VersionCheckTest to use logback-core 1.5.25

ceki · ceki · commit 8bd5660bdb4b · 2026-01-24T21:07:10.000+01:00
Signed-off-by: ceki &lt;ceki@qos.ch&gt;
diff --git a/logback-classic-blackbox/pom.xml b/logback-classic-blackbox/pom.xml
@@ -130,7 +130,7 @@
         <profile>
             <id>older-core</id>
             <properties>
-                <older-logback-core.version>1.5.20</older-logback-core.version>
+                <older-logback-core.version>1.5.25</older-logback-core.version>
             </properties>
             <dependencyManagement>
                 <dependencies>
diff --git a/logback-classic-blackbox/src/test/java/ch/qos/logback/classic/blackbox/VersionCheckTest.java b/logback-classic-blackbox/src/test/java/ch/qos/logback/classic/blackbox/VersionCheckTest.java
@@ -14,15 +14,14 @@
 
 package ch.qos.logback.classic.blackbox;
 
-import ch.qos.logback.classic.ClassicConstants;
 import ch.qos.logback.classic.LoggerContext;
 import ch.qos.logback.core.CoreConstants;
+import ch.qos.logback.core.util.CoreVersionUtil;
 import ch.qos.logback.core.util.VersionUtil;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.junit.jupiter.api.Assertions.fail;
 
 /**
@@ -59,9 +58,11 @@ public class VersionCheckTest {
      * 1.5.25 or older.
      */
     @Test
+    @Disabled
     public void versionTest() {
         String olderCoreVersion = System.getProperty("olderCore", "none");
-        assertEquals("1.5.20", olderCoreVersion);
+        //assertEquals("1.5.20", olderCoreVersion);
+        assertEquals("1.5.25", olderCoreVersion);
         try {
             VersionUtil.checkForVersionEquality(loggerContext, this.getClass(), CoreConstants.class, "logback-classic", "logback-core");
             fail("Expected NoClassDefFoundError");
@@ -71,6 +72,26 @@ public void versionTest() {
         }
     }
 
+    @Test
+    public void otherVersionTest() {
+        String olderCoreVersion = System.getProperty("olderCore", "none");
+        //assertEquals("1.5.20", olderCoreVersion);
+        assertEquals("1.5.25", olderCoreVersion);
+        try {
+            CoreVersionUtil.getCoreVersionBySelfDeclaredProperties();
+            fail("Expected Error");
+        } catch (NoClassDefFoundError e) {
+            // logback-core version is 1.5.24 or older
+            System.out.println("Got expected NoClassDefFoundError.");
+        } catch (NoSuchMethodError e) {
+            // logback-core version is 1.5.25 or older
+            System.out.println("Got expected NoSuchFieldError.");
+        }
+    }
+
+
+
+
     // WARNING: do not add other tests to this file
 
 }
diff --git a/logback-core/src/main/java/ch/qos/logback/core/util/CoreVersionUtil.java b/logback-core/src/main/java/ch/qos/logback/core/util/CoreVersionUtil.java
@@ -0,0 +1,18 @@
+/*
+ * Logback: the reliable, generic, fast and flexible logging framework.
+ *  Copyright (C) 1999-2026, QOS.ch. All rights reserved.
+ *
+ * This program and the accompanying materials are dual-licensed under
+ * either the terms of the Eclipse Public License v1.0 as published by
+ * the Eclipse Foundation
+ *
+ *     or (per the licensee's choosing)
+ *
+ * under the terms of the GNU Lesser General Public License version 2.1
+ * as published by the Free Software Foundation.
+ */
+
+package ch.qos.logback.core.util;
+
+public class CoreVersionUtil {
+}
