minor refactoring for better readability

ceki · ceki · commit 7ae0a7b6f0e9 · 2023-11-06T11:07:03.000+01:00
Signed-off-by: Ceki Gulcu &lt;ceki@qos.ch&gt;
diff --git a/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeAndTimeBasedFNATP.java b/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeAndTimeBasedFNATP.java
@@ -157,6 +157,10 @@ public boolean isTriggeringEvent(File activeFile, final E event) {
             return true;
         }
 
+        return checkSizeBasedTrigger(activeFile, currentTime);
+    }
+
+    private boolean checkSizeBasedTrigger(File activeFile, long currentTime) {
         // next check for roll-over based on size
         if (invocationGate.isTooSoon(currentTime)) {
             return false;
diff --git a/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java b/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java
@@ -227,6 +227,13 @@ public String getActiveFileName() {
         }
     }
 
+    /**
+     * Delegates to the underlying timeBasedFileNamingAndTriggeringPolicy.
+     *
+     * @param activeFile A reference to the currently active log file.
+     * @param event      A reference to the current event.
+     * @return
+     */
     public boolean isTriggeringEvent(File activeFile, final E event) {
         return timeBasedFileNamingAndTriggeringPolicy.isTriggeringEvent(activeFile, event);
     }

Original file line number	Diff line number	Diff line change
`@@ -227,6 +227,13 @@ public String getActiveFileName() {`
`227`	`227`	`}`
`228`	`228`	`}`
`229`	`229`
	`230`	`+ /**`
	`231`	`+ * Delegates to the underlying timeBasedFileNamingAndTriggeringPolicy.`
	`232`	`+ *`
	`233`	`+ * @param activeFile A reference to the currently active log file.`
	`234`	`+ * @param event A reference to the current event.`
	`235`	`+ * @return`
	`236`	`+ */`
`230`	`237`	`public boolean isTriggeringEvent(File activeFile, final E event) {`
`231`	`238`	`return timeBasedFileNamingAndTriggeringPolicy.isTriggeringEvent(activeFile, event);`
`232`	`239`	`}`