better to use BufferedOutputStream during ZIP and XZ compression, especially for non-Linux environments

ceki · ceki · commit 4627dbd618cb · 2025-12-21T18:10:25.000+01:00
Signed-off-by: ceki &lt;ceki@qos.ch&gt;
diff --git a/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/XZCompressionStrategy.java b/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/XZCompressionStrategy.java
@@ -13,10 +13,7 @@
  */
 package ch.qos.logback.core.rolling.helper;
 
-import java.io.BufferedInputStream;
-import java.io.File;
-import java.io.FileInputStream;
-import java.io.FileOutputStream;
+import java.io.*;
 
 import org.tukaani.xz.LZMA2Options;
 import org.tukaani.xz.XZOutputStream;
@@ -57,7 +54,7 @@ public void compress(String nameOfFile2xz, String nameOfxzedFile, String innerEn
         createMissingTargetDirsIfNecessary(xzedFile);
 
         try (FileInputStream fis = new FileInputStream(nameOfFile2xz);
-             XZOutputStream xzos = new XZOutputStream(new FileOutputStream(nameOfxzedFile), new LZMA2Options())) {
+             XZOutputStream xzos = new XZOutputStream(new BufferedOutputStream(new FileOutputStream(nameOfxzedFile), BUFFER_SIZE), new LZMA2Options())) {
 
             byte[] inbuf = new byte[BUFFER_SIZE];
             int n;
diff --git a/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/ZipCompressionStrategy.java b/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/ZipCompressionStrategy.java
@@ -16,8 +16,7 @@
 
 import ch.qos.logback.core.status.ErrorStatus;
 import ch.qos.logback.core.status.WarnStatus;
-
-import java.io.BufferedInputStream;
+import java.io.BufferedOutputStream;
 import java.io.File;
 import java.io.FileInputStream;
 import java.io.FileOutputStream;
@@ -64,7 +63,7 @@ public void compress(String originalFileName, String compressedFileName, String
         createMissingTargetDirsIfNecessary(zippedFile);
 
         try (FileInputStream fis = new FileInputStream(originalFileName);
-             ZipOutputStream zos = new ZipOutputStream(new FileOutputStream(compressedFileName))) {
+             ZipOutputStream zos = new ZipOutputStream(new BufferedOutputStream(new FileOutputStream(compressedFileName), BUFFER_SIZE))) {
 
             ZipEntry zipEntry = computeZipEntry(innerEntryName);
             zos.putNextEntry(zipEntry);
